1261 Raise An Issue Not Always Sending Slack Alerts #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sent for bug reports. Ensure bug report gets updated when initial create issue hook is called. Add indexes for search for bug reports by retries and timestamp. Added functions to update bug reports. Add constant for max number of retries. Ensure slack msg resend limit. Remove call to send slack msg when create issue hook is called so that scheduled task picks it up.
HalcyonJAC
reviewed
Nov 19, 2024
HalcyonJAC
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally the slack message doesnt get sent when the create issue github hook calls our backend.
This PR allows us to track whether this message was sent and, if not, retry sending the message several times (specified by a constant in the config).
Added a scheduled task which runs every 2 mins to look for bugReports which havent had a slack message sent. If it finds any it tries to send the slack message.
Also modified existing code to:
Closes #1261